linux-kernel - Re: [PATCH RFC v4 4/4] dt-binding: mmc: histb-dw-mshc: Add Hi3798MV200 compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 16 Apr 2023 19:23:02 +0800
From:   Yang Xiwen <forbidden405@...look.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Jaehoon Chung <jh80.chung@...sung.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     tianshuliang <tianshuliang@...ilicon.com>,
        Jiancheng Xue <xuejiancheng@...ilicon.com>,
        Shawn Guo <shawn.guo@...aro.org>,
        David Yang <mmyangfl@...il.com>, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH RFC v4 4/4] dt-binding: mmc: histb-dw-mshc: Add
 Hi3798MV200 compatible string

On 4/16/2023 7:16 PM, Krzysztof Kozlowski wrote:
> On 16/04/2023 11:19, Yang Xiwen via B4 Relay wrote:
>> From: Yang Xiwen <forbidden405@...look.com>
>>
>> Add Hi3798MV200 compatible string and an extra clock for it.
>>
>> Signed-off-by: Yang Xiwen <forbidden405@...look.com>
>> ---
>>  .../bindings/mmc/hisilicon,histb-dw-mshc.yaml      | 26 +++++++++++++++++++++-
>>  1 file changed, 25 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml
>> index 301b6ad39c5af..2f8335fd2c965 100644
>> --- a/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/hisilicon,histb-dw-mshc.yaml
>> @@ -19,6 +19,7 @@ properties:
>>    compatible:
>>      enum:
>>        - hisilicon,hi3798cv200-dw-mshc
>> +      - hisilicon,hi3798mv200-dw-mshc
>>  
>>    reg:
>>      maxItems: 1
>> @@ -27,14 +28,16 @@ properties:
>>      maxItems: 1
>>  
>>    clocks:
>> -    maxItems: 4
> 
> You miss now minItems. Are you sure you tested your bindings? This
> should fail.
> 
> Anyway, wait with sending new versions of patches to give other people
> chance to review. It's already second patchset today.
> 
> Best regards,
> Krzysztof
> 
Sorry for that. I'll fix that in v5 and send the new patchset a few days
later, waiting for others to review the driver.
-- 
Best regards,
Yang Xiwen