linux-kernel - Re: [PATCH 3/3] ARM: dts: sun8i: h3: beelink-x2: Disable DW-HDMI CEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 16 Apr 2023 16:47:28 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Jernej Škrabec <jernej.skrabec@...il.com>
Cc:     andrzej.hajda@...el.com, neil.armstrong@...aro.org,
        rfoss@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, wens@...e.org,
        samuel@...lland.org, jonas@...boo.se, airlied@...il.com,
        daniel@...ll.ch, dri-devel@...ts.freedesktop.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-media@...r.kernel.org, hverkuil-cisco@...all.nl
Subject: Re: [PATCH 3/3] ARM: dts: sun8i: h3: beelink-x2: Disable DW-HDMI CEC

On Sun, Apr 16, 2023 at 03:31:56PM +0200, Jernej Škrabec wrote:
> Dne nedelja, 16. april 2023 ob 15:25:31 CEST je Laurent Pinchart napisal(a):
> > Hi Jernej,
> > 
> > Thank you for the patch.
> > 
> > On Sat, Apr 15, 2023 at 12:46:13PM +0200, Jernej Skrabec wrote:
> > > Beelink X2 uses software implementation of CEC even though DW-HDMI has
> > > working hardware implementation.
> > 
> > Why ? The reason should be explained in the commit message.
> 
> Maybe I should reword this differently. It uses software implementation through 
> GPIO pin. Dedicated DW-HDMI CEC pin is left unconnected.

That's a very good reason :-) I'm then fine with this patch, with a
reworded commit message. The DT bindings should be updated accordingly
as well, to explain the use case.

> > > Disable unused DW-HDMI CEC.
> > > 
> > > Signed-off-by: Jernej Skrabec <jernej.skrabec@...il.com>
> > > ---
> > > 
> > >  arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> > > b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts index
> > > a6d38ecee141..38f40d69e5c5 100644
> > > --- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> > > +++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> > > @@ -150,6 +150,7 @@ &emac {
> > >  };
> > >  
> > >  &hdmi {
> > > +	snps,disable-cec;
> > >  	status = "okay";
> > >  };

-- 
Regards,

Laurent Pinchart