linux-kernel - Re: [PATCH 2/3] drm/bridge: dw_hdmi: Handle snps,disable-cec property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Apr 2023 15:32:47 +0200
From:   Robert Foss <rfoss@...nel.org>
To:     Jernej Skrabec <jernej.skrabec@...il.com>
Cc:     andrzej.hajda@...el.com, neil.armstrong@...aro.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        wens@...e.org, samuel@...lland.org, devicetree@...r.kernel.org,
        jonas@...boo.se, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, Laurent.pinchart@...asonboard.com,
        hverkuil-cisco@...all.nl, linux-sunxi@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org
Subject: Re: [PATCH 2/3] drm/bridge: dw_hdmi: Handle snps,disable-cec property

On Sat, Apr 15, 2023 at 12:47 PM Jernej Skrabec
<jernej.skrabec@...il.com> wrote:
>
> New DT property allows to skip CEC initialization.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@...il.com>
> ---
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 603bb3c51027..e7e8199d2fb1 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -3615,7 +3615,9 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev,
>                 hdmi->audio = platform_device_register_full(&pdevinfo);
>         }
>
> -       if (!plat_data->disable_cec && (config0 & HDMI_CONFIG0_CEC)) {
> +       if (!plat_data->disable_cec &&
> +           !of_property_read_bool(np, "snps,disable-cec") &&
> +           (config0 & HDMI_CONFIG0_CEC)) {
>                 cec.hdmi = hdmi;
>                 cec.ops = &dw_hdmi_cec_ops;
>                 cec.irq = irq;
> --
> 2.40.0
>


Reviewed-by: Robert Foss <rfoss@...nel.org>