| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <16d3bb91-af02-2504-1a8b-7805a2d30bb4@roeck-us.net>
Date: Sun, 16 Apr 2023 09:04:28 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Neil Armstrong <neil.armstrong@...aro.org>,
Kevin Hilman <khilman@...libre.com>,
Jerome Brunet <jbrunet@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
Julius Werner <jwerner@...omium.org>,
Evan Benn <evanbenn@...omium.org>,
Nicolas Ferre <nicolas.ferre@...rochip.com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Claudiu Beznea <claudiu.beznea@...rochip.com>,
Florian Fainelli <f.fainelli@...il.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Sander Vanheule <sander@...nheule.net>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Magnus Damm <magnus.damm@...il.com>,
Fu Wei <fu.wei@...aro.org>, Viresh Kumar <vireshk@...nel.org>,
Eugen Hristev <eugen.hristev@...labora.com>,
Justin Chen <justinpopo6@...il.com>,
�ecki <rafal@...ecki.pl>,
Linus Walleij <linus.walleij@...aro.org>,
Corentin Labbe <clabbe@...libre.com>,
Anson Huang <Anson.Huang@....com>,
Robert Marko <robert.marko@...tura.hr>,
Sergio Paracuellos <sergio.paracuellos@...il.com>,
Sai Prakash Ranjan <quic_saipraka@...cinc.com>,
Wolfram Sang <wsa+renesas@...g-engineering.com>,
Jamie Iles <jamie@...ieiles.com>,
Yannick Fertre <yannick.fertre@...s.st.com>,
Christophe Roullier <christophe.roullier@...s.st.com>,
Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>,
Srinivas Neeli <srinivas.neeli@...inx.com>,
linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-mediatek@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: watchdog: drop duplicated GPIO watchdog
bindings
On 4/15/23 02:51, Krzysztof Kozlowski wrote:
> Two conversions to DT schema of GPIO watchdog binding happened and came
> through different trees. Merge them into one:
> 1. Combine maintainers,
> 2. Use more descriptive property descriptions and constraints from
> gpio-wdt.yaml,
> 3. Switch to unevaluatedProperties:false, to allow generic watchdog
> properties.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
For the series:
Reviewed-by: Guenter Roeck <linux@...ck-us.net>
On a side note, the e-mail addresses in patchwork are messed up for
patches sent by you. As result, I can not reply to your e-mails after
pulling a patch from patchwork. This means that some replies get lost
if I did not keep the original e-mail.
That is how it looks like after I pull one of your patches from patchwork:
To:
+=?unknown-8bit?q?Wim_Van_Sebroeck_=3Cwim=40linux-watchdog=2Eorg=3E=2C_Gu?==?unknown-8bit?q?enter_Roeck_=3Clinux=40roeck-us=2Enet=3E=2C_Rob_Herring_?==?unknown-8bit?q?=3Crobh+dt=40kernel=2Eorg=3E=2C_Krzysztof_Kozlowski_=3Ckrz?==?unknown-8bit?q?yszt
+of=2Ekozlowski+dt=40linaro=2Eorg=3E=2C_Neil_Armstrong_?==?unknown-8bit?q?=3Cneil=2Earmstrong=40linaro=2Eorg=3E=2C_Kevin_Hilman_=3Ck?==?unknown-8bit?q?hilman=40baylibre=2Ecom=3E=2C_Jerome_Brunet_=3Cjbrunet=40b?==?unknown-8bit?q?aylibre=2Ecom=3E=2C_
+Martin_Blumenstingl_=3Cmartin=2Eblumen?==?unknown-8bit?q?stingl=40googlemail=2Ecom=3E=2C_Julius_Werner_=3Cjwerner?==?unknown-8bit?q?=40chromium=2Eorg=3E=2C_Evan_Benn_=3Cevanbenn=40chromium?==?unknown-8bit?q?=2Eorg=3E=2C_Nicolas_Ferre_=3Cnicolas=2E
+ferre=40microchip?==?unknown-8bit?q?=2Ecom=3E=2C_Alexandre_Belloni_=3Calexandre=2Ebelloni=40bo?==?unknown-8bit?q?otlin=2Ecom=3E=2C_Claudiu_Beznea_=3Cclaudiu=2Ebeznea=40mic?==?unknown-8bit?q?rochip=2Ecom=3E=2C_Florian_Fainelli_=3Cf=2Efainelli=40gma
+i?==?unknown-8bit?q?l=
Guenter
> ---
> .../bindings/watchdog/gpio-wdt.yaml | 55 -------------------
> .../bindings/watchdog/linux,wdt-gpio.yaml | 17 +++++-
> 2 files changed, 15 insertions(+), 57 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/watchdog/gpio-wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/gpio-wdt.yaml b/Documentation/devicetree/bindings/watchdog/gpio-wdt.yaml
> deleted file mode 100644
> index 155dc7965e9b..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/gpio-wdt.yaml
> +++ /dev/null
> @@ -1,55 +0,0 @@
> -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> -%YAML 1.2
> ----
> -$id: http://devicetree.org/schemas/watchdog/gpio-wdt.yaml#
> -$schema: http://devicetree.org/meta-schemas/core.yaml#
> -
> -title: GPIO controlled watchdog
> -
> -maintainers:
> - - Robert Marko <robert.marko@...tura.hr>
> -
> -properties:
> - compatible:
> - const: linux,wdt-gpio
> -
> - gpios:
> - maxItems: 1
> - description: GPIO connected to the WDT reset pin
> -
> - hw_algo:
> - $ref: /schemas/types.yaml#/definitions/string
> - description: Algorithm used by the driver
> - oneOf:
> - - description:
> - Either a high-to-low or a low-to-high transition clears the WDT counter.
> - The watchdog timer is disabled when GPIO is left floating or connected
> - to a three-state buffer.
> - const: toggle
> - - description:
> - Low or high level starts counting WDT timeout, the opposite level
> - disables the WDT.
> - Active level is determined by the GPIO flags.
> - const: level
> -
> - hw_margin_ms:
> - $ref: /schemas/types.yaml#/definitions/uint32
> - description: Maximum time to reset watchdog circuit (in milliseconds)
> - minimum: 2
> - maximum: 65535
> -
> - always-running:
> - type: boolean
> - description:
> - If the watchdog timer cannot be disabled, add this flag to have the driver
> - keep toggling the signal without a client.
> - It will only cease to toggle the signal when the device is open and the
> - timeout elapsed.
> -
> -required:
> - - compatible
> - - gpios
> - - hw_algo
> - - hw_margin_ms
> -
> -unevaluatedProperties: false
> diff --git a/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml b/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml
> index 50af79af6416..499f1b7e03f9 100644
> --- a/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml
> @@ -8,6 +8,7 @@ title: GPIO-controlled Watchdog
>
> maintainers:
> - Guenter Roeck <linux@...ck-us.net>
> + - Robert Marko <robert.marko@...tura.hr>
>
> properties:
> compatible:
> @@ -19,11 +20,23 @@ properties:
>
> hw_algo:
> description: The algorithm used by the driver.
> - enum: [ level, toggle ]
> + oneOf:
> + - description:
> + Either a high-to-low or a low-to-high transition clears the WDT counter.
> + The watchdog timer is disabled when GPIO is left floating or connected
> + to a three-state buffer.
> + const: toggle
> + - description:
> + Low or high level starts counting WDT timeout, the opposite level
> + disables the WDT.
> + Active level is determined by the GPIO flags.
> + const: level
>
> hw_margin_ms:
> description: Maximum time to reset watchdog circuit (milliseconds).
> $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 2
> + maximum: 65535
>
> always-running:
> type: boolean
> @@ -42,7 +55,7 @@ required:
> allOf:
> - $ref: watchdog.yaml#
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |
Powered by blists - more mailing lists