linux-kernel - Re: [PATCH v2] staging: wlan-ng: replace rate macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f44f44e4-25c0-4489-96e9-8ca63fa294d7@kili.mountain>
Date:   Mon, 17 Apr 2023 11:04:04 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Luke Koch <lu.ale.koch@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: wlan-ng: replace rate macros

On Sat, Apr 15, 2023 at 04:10:44PM +0200, Luke Koch wrote:
> +	for (int i = 0; i < 8; i++) {
> +		if (count > i &&
> +		    DOT11_RATE5_ISBASIC_GET(item->supprates[i])) {
> +			req->basicrate[i] .data = item->supprates[i];
                                         ^
Could you remove these spaces before the .data and .status?  Otherwise
it looks good to me.

Reviewed-by: Dan Carpenter <error27@...il.com>

regards,
dan carpenter