linux-kernel - Re: [PATCH v2] staging: wlan-ng: replace rate macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZD0ChREQnV8tKwS1@kernelhacking.kernelhacking.example.com>
Date:   Mon, 17 Apr 2023 10:25:41 +0200
From:   Luke Koch <lu.ale.koch@...il.com>
To:     Dan Carpenter <error27@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: wlan-ng: replace rate macros

On Mon, Apr 17, 2023 at 11:04:04AM +0300, Dan Carpenter wrote:
> On Sat, Apr 15, 2023 at 04:10:44PM +0200, Luke Koch wrote:
> > +	for (int i = 0; i < 8; i++) {
> > +		if (count > i &&
> > +		    DOT11_RATE5_ISBASIC_GET(item->supprates[i])) {
> > +			req->basicrate[i] .data = item->supprates[i];
>                                          ^
> Could you remove these spaces before the .data and .status?  Otherwise
> it looks good to me.

Sure, the spaces must have been leftovers from the token pasting and I
unfortunately overlooked them. Thanks for reviewing!

Best regards,
Luke Koch