lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZD0iycNg4i6sYO48@smile.fi.intel.com>
Date:   Mon, 17 Apr 2023 13:43:21 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Joy Chakraborty <joychakr@...gle.com>
Cc:     Serge Semin <fancer.lancer@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org, manugautam@...gle.com,
        rohitner@...gle.com
Subject: Re: [PATCH v6 2/5] spi: dw: Move "dw_spi_can_dma" function

On Fri, Apr 14, 2023 at 12:05:17PM +0000, Joy Chakraborty wrote:
> Move "dw_spi_can_dma" function implementation below
> "dw_spi_dma_convert_width" function for handing compile dependency in
> future patches.

We refer to the functions like func().

...

> +static bool dw_spi_can_dma(struct spi_controller *master,
> +			   struct spi_device *spi, struct spi_transfer *xfer)
> +{
> +	struct dw_spi *dws = spi_controller_get_devdata(master);
> +
> +	return xfer->len > dws->fifo_len;
> +}

> +
> +

Single blank line is enough.

-- 
With Best Regards,
Andy Shevchenko


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ