linux-kernel - Re: [PATCH v1 1/1] PCI: of: Propagate firmware node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZD0jNxUjLIjyiiy/@smile.fi.intel.com>
Date:   Mon, 17 Apr 2023 13:45:11 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Pali Rohár <pali@...nel.org>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH v1 1/1] PCI: of: Propagate firmware node

On Fri, Apr 14, 2023 at 01:55:45PM -0500, Bjorn Helgaas wrote:
> On Thu, Apr 13, 2023 at 07:00:26PM +0300, Andy Shevchenko wrote:
> > On Wed, Apr 12, 2023 at 11:02:53AM -0500, Bjorn Helgaas wrote:
> > > On Wed, Apr 12, 2023 at 04:15:20PM +0300, Andy Shevchenko wrote:

...

> > > > Propagate firmware node by using a specific API call, i.e. device_set_node().
> > > 
> > > Can you add a line or two about *why* we should do this, e.g., is this
> > > headed toward some goal?
> > 
> > Because dereferencing the fwnode in struct device is preventing us from
> > modifications of how fwnode looks like in the future.
> 
> How do you want to express this in the commit log?  Something like
> this?
> 
>   Insulate pci_set_of_node() and pci_set_bus_of_node() from possible
>   changes to fwnode_handle implementation by using device_set_node()
>   instead of open-coding dev->dev.fwnode assignments.

Sounds good to me, thanks for the draft. I will do it in v2 this way.

-- 
With Best Regards,
Andy Shevchenko