linux-kernel - Re: [PATCH] clocksource: ti: Use of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230418162437.GB1764573-robh@kernel.org>
Date:   Tue, 18 Apr 2023 11:24:37 -0500
From:   Rob Herring <robh@...nel.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource: ti: Use of_property_read_bool() for boolean
 properties

On Fri, Mar 10, 2023 at 08:47:01AM -0600, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties.
> Convert reading boolean properties to to of_property_read_bool().
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  drivers/clocksource/timer-ti-dm-systimer.c | 4 ++--
>  drivers/clocksource/timer-ti-dm.c          | 8 ++++----
>  2 files changed, 6 insertions(+), 6 deletions(-)

Ping!

> 
> diff --git a/drivers/clocksource/timer-ti-dm-systimer.c b/drivers/clocksource/timer-ti-dm-systimer.c
> index 632523c1232f..efa5f55a65f8 100644
> --- a/drivers/clocksource/timer-ti-dm-systimer.c
> +++ b/drivers/clocksource/timer-ti-dm-systimer.c
> @@ -586,7 +586,7 @@ static int __init dmtimer_clkevt_init_common(struct dmtimer_clockevent *clkevt,
>  	writel_relaxed(OMAP_TIMER_INT_OVERFLOW, t->base + t->wakeup);
>  
>  	pr_info("TI gptimer %s: %s%lu Hz at %pOF\n",
> -		name, of_find_property(np, "ti,timer-alwon", NULL) ?
> +		name, of_property_read_bool(np, "ti,timer-alwon") ?
>  		"always-on " : "", t->rate, np->parent);
>  
>  	return 0;
> @@ -787,7 +787,7 @@ static int __init dmtimer_clocksource_init(struct device_node *np)
>  		       t->base + t->ctrl);
>  
>  	pr_info("TI gptimer clocksource: %s%pOF\n",
> -		of_find_property(np, "ti,timer-alwon", NULL) ?
> +		of_property_read_bool(np, "ti,timer-alwon") ?
>  		"always-on " : "", np->parent);
>  
>  	if (!dmtimer_sched_clock_counter) {
> diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
> index b24b903a8822..7031aa1bfdcb 100644
> --- a/drivers/clocksource/timer-ti-dm.c
> +++ b/drivers/clocksource/timer-ti-dm.c
> @@ -1104,13 +1104,13 @@ static int omap_dm_timer_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, timer);
>  
>  	if (dev->of_node) {
> -		if (of_find_property(dev->of_node, "ti,timer-alwon", NULL))
> +		if (of_property_read_bool(dev->of_node, "ti,timer-alwon"))
>  			timer->capability |= OMAP_TIMER_ALWON;
> -		if (of_find_property(dev->of_node, "ti,timer-dsp", NULL))
> +		if (of_property_read_bool(dev->of_node, "ti,timer-dsp"))
>  			timer->capability |= OMAP_TIMER_HAS_DSP_IRQ;
> -		if (of_find_property(dev->of_node, "ti,timer-pwm", NULL))
> +		if (of_property_read_bool(dev->of_node, "ti,timer-pwm"))
>  			timer->capability |= OMAP_TIMER_HAS_PWM;
> -		if (of_find_property(dev->of_node, "ti,timer-secure", NULL))
> +		if (of_property_read_bool(dev->of_node, "ti,timer-secure"))
>  			timer->capability |= OMAP_TIMER_SECURE;
>  	} else {
>  		timer->id = pdev->id;
> -- 
> 2.39.2
>