linux-kernel - Re: [PATCH] ALSA: Use of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230418162557.GD1764573-robh@kernel.org>
Date:   Tue, 18 Apr 2023 11:25:57 -0500
From:   Rob Herring <robh@...nel.org>
To:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc:     devicetree@...r.kernel.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: Use of_property_read_bool() for boolean properties

On Fri, Mar 10, 2023 at 08:47:33AM -0600, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties.
> Convert reading boolean properties to to of_property_read_bool().
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  sound/ppc/tumbler.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ping!

> 
> diff --git a/sound/ppc/tumbler.c b/sound/ppc/tumbler.c
> index 6c882873b344..12f1e10db1c4 100644
> --- a/sound/ppc/tumbler.c
> +++ b/sound/ppc/tumbler.c
> @@ -1361,7 +1361,7 @@ int snd_pmac_tumbler_init(struct snd_pmac *chip)
>  
>  	for_each_child_of_node(chip->node, np) {
>  		if (of_node_name_eq(np, "sound")) {
> -			if (of_get_property(np, "has-anded-reset", NULL))
> +			if (of_property_read_bool(np, "has-anded-reset"))
>  				mix->anded_reset = 1;
>  			if (of_property_present(np, "layout-id"))
>  				mix->reset_on_sleep = 0;
> -- 
> 2.39.2
>