linux-kernel - Re: [PATCH 2/2] iio: light: Add support for TI OPT4001 light sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83ac1bd0-13c4-1c4b-9d1b-7205c34122ad@linaro.org>
Date:   Tue, 18 Apr 2023 18:35:15 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@...s.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...s.com
Subject: Re: [PATCH 2/2] iio: light: Add support for TI OPT4001 light sensor

On 18/04/2023 18:34, Krzysztof Kozlowski wrote:
> On 04/04/2023 11:07, Stefan Windfeldt-Prytz wrote:
>> This driver uses the continuous mode of the chip and integration
>> time can be configured through sysfs.
>> The constants for calculating lux value differs between packaging
>> so it uses different compatible string for the two versions
>> "ti,opt4001-picostar" and "ti,opt4001-sot-5x3" since the device id
>> is the same.
> 
> Thank you for your patch. There is something to discuss/improve.
> 
>> +
>> +	indio_dev->channels = opt4001_channels;
>> +	indio_dev->num_channels = ARRAY_SIZE(opt4001_channels);
>> +	indio_dev->modes = INDIO_DIRECT_MODE;
>> +	indio_dev->name = chip->client->name;
>> +
>> +	of_id = of_match_device(of_match_ptr(opt4001_of_match), &client->dev);
> 
> ? Drop of_match_ptr

Ah, this is old patch... so maybe you already did this.

Best regards,
Krzysztof