linux-kernel - Re: [PATCH] mailbox: Use of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABb+yY3Y8oZYG1y8zfTCC8g7=T0HQp3G3N_iECudo1gduYpy-A@mail.gmail.com>
Date:   Tue, 18 Apr 2023 11:36:22 -0500
From:   Jassi Brar <jassisinghbrar@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mailbox: Use of_property_read_bool() for boolean properties

On Tue, Apr 18, 2023 at 11:25 AM Rob Herring <robh@...nel.org> wrote:
>
> On Fri, Mar 10, 2023 at 08:47:10AM -0600, Rob Herring wrote:
> > It is preferred to use typed property access functions (i.e.
> > of_property_read_<type> functions) rather than low-level
> > of_get_property/of_find_property functions for reading properties.
> > Convert reading boolean properties to to of_property_read_bool().
> >
> > Signed-off-by: Rob Herring <robh@...nel.org>
> > ---
> >  drivers/mailbox/hi6220-mailbox.c | 5 +----
> >  drivers/mailbox/omap-mailbox.c   | 3 +--
> >  2 files changed, 2 insertions(+), 6 deletions(-)
>
> Ping!
>
Pong :)

I don't usually reply back that it looks good and will pick for the
merge window. I just do that. So yes, it is not overlooked.

cheers