linux-kernel - Re: [PATCH v4 11/11] PCI: rockchip: Set address alignment for endpoint mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Apr 2023 09:11:07 +0200
From:   Rick Wertenbroek <rick.wertenbroek@...il.com>
To:     Damien Le Moal <dlemoal@...nel.org>
Cc:     alberto.dassatti@...g-vd.ch, xxm@...k-chips.com,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Johan Jonker <jbx6244@...il.com>,
        Caleb Connolly <kc@...tmarketos.org>,
        Brian Norris <briannorris@...omium.org>,
        Corentin Labbe <clabbe@...libre.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Hugh Cole-Baker <sigmaris@...il.com>,
        Judy Hsiao <judyhsiao@...omium.org>,
        Arnaud Ferraris <arnaud.ferraris@...labora.com>,
        linux-pci@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 11/11] PCI: rockchip: Set address alignment for
 endpoint mode

On Tue, Apr 18, 2023 at 1:51 AM Damien Le Moal <dlemoal@...nel.org> wrote:
>
> On 4/17/23 18:26, Rick Wertenbroek wrote:
> > From: Damien Le Moal <dlemoal@...nel.org>
> >
> > The address translation unit of the rockchip EP controller does not use
> > the lower 8 bits of a PCIe-space address to map local memory. Thus we
> > must set the align feature field to 256 to let the user know about this
> > constraint.
> >
> > Signed-off-by: Damien Le Moal <dlemoal@...nel.org>
>
> I think this one also needs the tag:
>
> Fixes: cf590b078391 ("...")
> Cc: stable@...r.kernel.org
>
> And you forgot to add you Signed-off-by tag (when sending someones else patch,
> you must add your own SoB tag after the author's tag).
>

Thank you for all your comments, I'll add the tags.
I reread the documentation, I missed it, it's the first
time I sent someone elses patch.

> > ---
> >  drivers/pci/controller/pcie-rockchip-ep.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c
> > index edfced311a9f..0af0e965fb57 100644
> > --- a/drivers/pci/controller/pcie-rockchip-ep.c
> > +++ b/drivers/pci/controller/pcie-rockchip-ep.c
> > @@ -442,6 +442,7 @@ static const struct pci_epc_features rockchip_pcie_epc_features = {
> >       .linkup_notifier = false,
> >       .msi_capable = true,
> >       .msix_capable = false,
> > +     .align = 256,
> >  };
> >
> >  static const struct pci_epc_features*
>