linux-kernel - Re: [PATCH] soc: mdediatek: devapc: use devm_platform_ioremap_resource() instead of of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bfd1641-3f58-ca6e-1e80-13acea834ea5@collabora.com>
Date:   Tue, 18 Apr 2023 12:09:17 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     zhengkang huang <zkhuang@...t.edu.cn>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     Dongliang Mu <dzm91@...t.edu.cn>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] soc: mdediatek: devapc: use
 devm_platform_ioremap_resource() instead of of_iomap()

Il 14/04/23 11:21, zhengkang huang ha scritto:
> In mtk_devapc_probe(), if of_iomap succeeds and any following error occurs,
> it needs to deallocate the resource.
> 
> Fix this by repalcing of_iomap with devm_platform_ioremap_resource, which
> automatically self-manages the resource. This can avoid modifying error
> handling code.
> 
> Signed-off-by: zhengkang huang <zkhuang@...t.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>

You haven't tested this patch on any MediaTek SoC, have you?

This will break devapc.

Regards,
Angelo