linux-kernel - Re: [PATCH] soc: mdediatek: devapc: use devm_platform_ioremap_resource() instead of of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3a4c253-a9a8-9a6b-b5f1-cf4dd0615b5e@hust.edu.cn>
Date:   Tue, 18 Apr 2023 19:49:12 +0800
From:   Dongliang Mu <dzm91@...t.edu.cn>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        zhengkang huang <zkhuang@...t.edu.cn>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] soc: mdediatek: devapc: use
 devm_platform_ioremap_resource() instead of of_iomap()


On 2023/4/18 18:09, AngeloGioacchino Del Regno wrote:
> Il 14/04/23 11:21, zhengkang huang ha scritto:
>> In mtk_devapc_probe(), if of_iomap succeeds and any following error 
>> occurs,
>> it needs to deallocate the resource.
>>
>> Fix this by repalcing of_iomap with devm_platform_ioremap_resource, 
>> which
>> automatically self-manages the resource. This can avoid modifying error
>> handling code.
>>
>> Signed-off-by: zhengkang huang <zkhuang@...t.edu.cn>
>> Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>
>
> You haven't tested this patch on any MediaTek SoC, have you?

Yes, this issue is found by static analysis and remains untested.

Sorry for the functionablity issue.

Dongliang Mu

>
> This will break devapc.
>
> Regards,
> Angelo
>