linux-kernel - drivers/atm/iphase.c:151 ia_hack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Tue, 18 Apr 2023 21:52:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Stafford Horne <shorne@...il.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: drivers/atm/iphase.c:151 ia_hack_tcq() warn: if();

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   6a8f57ae2eb07ab39a6f0ccad60c760743051026
commit: ded2ee36313c941f1a12b6f85cde295b575264ae openrisc: Add pci bus support
date:   9 months ago
config: openrisc-randconfig-m031-20230416 (https://download.01.org/0day-ci/archive/20230418/202304182100.xKJSzynK-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304182100.xKJSzynK-lkp@intel.com/

New smatch warnings:
drivers/atm/iphase.c:151 ia_hack_tcq() warn: if();
drivers/atm/iphase.c:562 ia_cbr_setup() warn: inconsistent indenting
drivers/atm/iphase.c:695 ia_tx_poll() warn: inconsistent indenting
drivers/atm/iphase.c:1247 rx_intr() warn: inconsistent indenting
drivers/atm/iphase.c:1558 rx_init() warn: inconsistent indenting
drivers/atm/iphase.c:1763 open_tx() warn: inconsistent indenting
drivers/atm/iphase.c:2553 ia_start() warn: inconsistent indenting
drivers/atm/iphase.c:2766 ia_ioctl() warn: inconsistent indenting
drivers/atm/iphase.c:2911 ia_pkt_tx() warn: inconsistent indenting

Old smatch warnings:
drivers/atm/iphase.c:2870 ia_ioctl() warn: inconsistent indenting

vim +151 drivers/atm/iphase.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  143  
^1da177e4c3f41 Linus Torvalds 2005-04-16  144    u_short 		desc1;
^1da177e4c3f41 Linus Torvalds 2005-04-16  145    u_short		tcq_wr;
^1da177e4c3f41 Linus Torvalds 2005-04-16  146    struct ia_vcc         *iavcc_r = NULL; 
^1da177e4c3f41 Linus Torvalds 2005-04-16  147  
^1da177e4c3f41 Linus Torvalds 2005-04-16  148    tcq_wr = readl(dev->seg_reg+TCQ_WR_PTR) & 0xffff;
^1da177e4c3f41 Linus Torvalds 2005-04-16  149    while (dev->host_tcq_wr != tcq_wr) {
^1da177e4c3f41 Linus Torvalds 2005-04-16  150       desc1 = *(u_short *)(dev->seg_ram + dev->host_tcq_wr);
^1da177e4c3f41 Linus Torvalds 2005-04-16 @151       if (!desc1) ;
^1da177e4c3f41 Linus Torvalds 2005-04-16  152       else if (!dev->desc_tbl[desc1 -1].timestamp) {
^1da177e4c3f41 Linus Torvalds 2005-04-16  153          IF_ABR(printk(" Desc %d is reset at %ld\n", desc1 -1, jiffies);)
^1da177e4c3f41 Linus Torvalds 2005-04-16  154          *(u_short *) (dev->seg_ram + dev->host_tcq_wr) = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16  155       }                                 
^1da177e4c3f41 Linus Torvalds 2005-04-16  156       else if (dev->desc_tbl[desc1 -1].timestamp) {
^1da177e4c3f41 Linus Torvalds 2005-04-16  157          if (!(iavcc_r = dev->desc_tbl[desc1 -1].iavcc)) { 
^1da177e4c3f41 Linus Torvalds 2005-04-16  158             printk("IA: Fatal err in get_desc\n");
^1da177e4c3f41 Linus Torvalds 2005-04-16  159             continue;
^1da177e4c3f41 Linus Torvalds 2005-04-16  160          }
^1da177e4c3f41 Linus Torvalds 2005-04-16  161          iavcc_r->vc_desc_cnt--;
^1da177e4c3f41 Linus Torvalds 2005-04-16  162          dev->desc_tbl[desc1 -1].timestamp = 0;
849e8caa477d72 David Howells  2008-07-30  163          IF_EVENT(printk("ia_hack: return_q skb = 0x%p desc = %d\n",
849e8caa477d72 David Howells  2008-07-30  164                                     dev->desc_tbl[desc1 -1].txskb, desc1);)
^1da177e4c3f41 Linus Torvalds 2005-04-16  165          if (iavcc_r->pcr < dev->rate_limit) {
^1da177e4c3f41 Linus Torvalds 2005-04-16  166             IA_SKB_STATE (dev->desc_tbl[desc1-1].txskb) |= IA_TX_DONE;
^1da177e4c3f41 Linus Torvalds 2005-04-16  167             if (ia_enque_rtn_q(&dev->tx_return_q, dev->desc_tbl[desc1 -1]) < 0)
^1da177e4c3f41 Linus Torvalds 2005-04-16  168                printk("ia_hack_tcq: No memory available\n");
^1da177e4c3f41 Linus Torvalds 2005-04-16  169          } 
^1da177e4c3f41 Linus Torvalds 2005-04-16  170          dev->desc_tbl[desc1 -1].iavcc = NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16  171          dev->desc_tbl[desc1 -1].txskb = NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16  172       }
^1da177e4c3f41 Linus Torvalds 2005-04-16  173       dev->host_tcq_wr += 2;
^1da177e4c3f41 Linus Torvalds 2005-04-16  174       if (dev->host_tcq_wr > dev->ffL.tcq_ed) 
^1da177e4c3f41 Linus Torvalds 2005-04-16  175          dev->host_tcq_wr = dev->ffL.tcq_st;
^1da177e4c3f41 Linus Torvalds 2005-04-16  176    }
^1da177e4c3f41 Linus Torvalds 2005-04-16  177  } /* ia_hack_tcq */
^1da177e4c3f41 Linus Torvalds 2005-04-16  178  

:::::: The code at line 151 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests