linux-kernel - Re: [PATCH net v3] net: ethernet: fix use after free bug in ns83820_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230418213340.153529d7@kernel.org>
Date:   Tue, 18 Apr 2023 21:33:40 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Zheng Wang <zyytlz.wz@....com>
Cc:     davem@...emloft.net, horatiu.vultur@...rochip.com,
        edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, hackerzheng666@...il.com,
        1395428693sheep@...il.com, alex000young@...il.com
Subject: Re: [PATCH net v3] net: ethernet: fix use after free bug in
 ns83820_remove_one  due to race condition

On Mon, 17 Apr 2023 09:31:07 +0800 Zheng Wang wrote:
> +	netif_carrier_off(ndev);
> +	netif_tx_disable(ndev);
> +
>  	unregister_netdev(ndev

It's not immediately obvious to me why disabling carrier and tx
are supposed to help. Please elaborate in the commit message if
you're confident that this is right.

-- 
pw-bot: cr