linux-kernel - Re: [PATCH] migrate_pages_batch: fix statistics for longterm pin retry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e01cdedf-243d-038e-bb77-aea34e39658c@linux.alibaba.com>
Date:   Wed, 19 Apr 2023 15:34:54 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     Huang Ying <ying.huang@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Alistair Popple <apopple@...dia.com>,
        David Hildenbrand <david@...hat.com>,
        Yang Shi <shy828301@...il.com>, Zi Yan <ziy@...dia.com>
Subject: Re: [PATCH] migrate_pages_batch: fix statistics for longterm pin
 retry



On 4/17/2023 7:59 AM, Huang Ying wrote:
> In commit fd4a7ac32918 ("mm: migrate: try again if THP split is failed
> due to page refcnt"), if the THP splitting fails due to page reference
> count, we will retry to improve migration successful rate.  But the
> failed splitting is counted as migration failure and migration retry,
> which will cause duplicated failure counting.  So, in this patch, this
> is fixed via undoing the failure counting if we decide to retry.  The
> patch is tested via failure injection.

Makes sense to me. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

> Fixes: fd4a7ac32918 ("mm: migrate: try again if THP split is failed due to page refcnt")
> Signed-off-by: "Huang, Ying" <ying.huang@...el.com>
> Cc: Baolin Wang <baolin.wang@...ux.alibaba.com>
> Cc: Alistair Popple <apopple@...dia.com>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Yang Shi <shy828301@...il.com>
> Cc: Zi Yan <ziy@...dia.com>
> ---
>   mm/migrate.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/mm/migrate.c b/mm/migrate.c
> index b34a0f383795..47a1e8445f45 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -1743,6 +1743,9 @@ static int migrate_pages_batch(struct list_head *from, new_page_t get_new_page,
>   							large_retry++;
>   							thp_retry += is_thp;
>   							nr_retry_pages += nr_pages;
> +							/* Undo duplicated failure counting. */
> +							nr_large_failed--;
> +							stats->nr_thp_failed -= is_thp;
>   							break;
>   						}
>   					}