linux-kernel - Re: [PATCH] PCI: Restrict device disabled status check to DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87leimnboj.fsf@redhat.com>
Date:   Thu, 20 Apr 2023 11:30:04 +0200
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     Bjorn Helgaas <helgaas@...nel.org>, Rob Herring <robh@...nel.org>
Cc:     Donald Hunter <donald.hunter@...il.com>,
        Binbin Zhou <zhoubinbin@...ngson.cn>,
        Liu Peibao <liupeibao@...ngson.cn>,
        Huacai Chen <chenhuacai@...ngson.cn>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        regressions@...ts.linux.dev, mstowe@...hat.com
Subject: Re: [PATCH] PCI: Restrict device disabled status check to DT

Bjorn Helgaas <helgaas@...nel.org> writes:

> [+cc Vitaly, Jesse, Tony, Andy, regressions, regarding reports of
> hang or crash during boot in igb driver, some with AWS Xen]
>
> On Wed, Apr 19, 2023 at 02:35:13PM -0500, Rob Herring wrote:
>> Commit 6fffbc7ae137 ("PCI: Honor firmware's device disabled status")
>> checked the firmware device status for both DT and ACPI devices. That
>> caused a regression in some ACPI systems. The exact reason isn't clear.
>> It's possibly a firmware bug. For now, at least, refactor the check to
>> be for DT based systems only.
>> 
>> Note that the original implementation leaked a refcount which is now
>> correctly handled.
>> 
>> Fixes: 6fffbc7ae137 ("PCI: Honor firmware's device disabled status")
>> Link: https://lore.kernel.org/all/m2fs9lgndw.fsf@gmail.com/
>> Reported-by: Donald Hunter <donald.hunter@...il.com>
>> Cc: Binbin Zhou <zhoubinbin@...ngson.cn>
>> Cc: Liu Peibao <liupeibao@...ngson.cn>
>> Cc: Huacai Chen <chenhuacai@...ngson.cn>
>> Signed-off-by: Rob Herring <robh@...nel.org>
>
> Applied to for-linus for (hopefully) v6.3.  I added:
>
>   [bhelgaas: Per ACPI r6.5, sec 6.3.7, for devices on an enumerable
>   bus, _STA must return with bit[0] ("device is present") set]
>
>   Link: https://bugzilla.kernel.org/show_bug.cgi?id=217317
>
> It would be really great if anybody who has seen this issue could test
> and report whether this patch solves it.
>

[Cc: Myron]

I can confirm the patch fixes the issue I've reported with AWS Xen
instances, so:

Tested-by:  Vitaly Kuznetsov <vkuznets@...hat.com>

-- 
Vitaly