linux-kernel - Re: [PATCH 04/10] ARM: dts: qcom: ipq8064: drop leading 0 from unit-address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98d8fb6c-5e64-43be-17d5-ae37db69201b@linaro.org>
Date:   Thu, 20 Apr 2023 12:46:46 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/10] ARM: dts: qcom: ipq8064: drop leading 0 from
 unit-address



On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> Unit-address should not start with 0:
> 
>   Warning (simple_bus_reg): /soc/syscon@...00000: simple-bus unit address format error, expected "3000000"
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

>  arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> index 621edf508a88..182018d79a7b 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> @@ -609,7 +609,7 @@ saw1: regulator@...9000 {
>  			regulator;
>  		};
>  
> -		nss_common: syscon@...00000 {
> +		nss_common: syscon@...0000 {
>  			compatible = "syscon";
>  			reg = <0x03000000 0x0000FFFF>;
some random uppercase hex, if you'd like to clean that up too!

Konrad

>  		};