linux-kernel - Re: [PATCH 05/10] ARM: dts: qcom: ipq8064: drop invalid GCC thermal-sensor unit-address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <776bb753-6302-b140-ab8d-fe6fb1b0bcf8@linaro.org>
Date:   Thu, 20 Apr 2023 12:48:06 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/10] ARM: dts: qcom: ipq8064: drop invalid GCC
 thermal-sensor unit-address



On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> GCC comes with syscon compatible so the thermal-sensor child node should
> not have unit-address (bindings also do not expect it):
> 
>   Warning (unit_address_vs_reg): /soc/clock-controller@...000/thermal-sensor@...000: node has a unit name, but no reg or ranges property
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> index 182018d79a7b..49310520da1c 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> @@ -522,7 +522,7 @@ gcc: clock-controller@...000 {
>  			#reset-cells = <1>;
>  			#power-domain-cells = <1>;
>  
> -			tsens: thermal-sensor@...000 {
> +			tsens: thermal-sensor {
>  				compatible = "qcom,ipq8064-tsens";
>  
>  				nvmem-cells = <&tsens_calib>, <&tsens_calib_backup>;