linux-kernel - Re: [PATCH] f2fs: remove unnessary comment in __may_age_extent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZELiCve2x31uJFhM@google.com>
Date:   Fri, 21 Apr 2023 12:20:42 -0700
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Chao Yu <chao@...nel.org>
Cc:     Qi Han <hanqi@...o.com>, linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree

On 04/21, Chao Yu wrote:
> On 2023/4/18 14:09, Qi Han wrote:
> > This comment make no sense and is in the wrong place, so let's
> > remove it.
> > 
> > Signed-off-by: Qi Han <hanqi@...o.com>
> > ---
> >   fs/f2fs/extent_cache.c | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
> > index 28b12553f2b3..1f6d7de35794 100644
> > --- a/fs/f2fs/extent_cache.c
> > +++ b/fs/f2fs/extent_cache.c
> > @@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode)
> >   	if (!test_opt(sbi, AGE_EXTENT_CACHE))
> >   		return false;
> > -	/* don't cache block age info for cold file */
> >   	if (is_inode_flag_set(inode, FI_COMPRESSED_FILE))
> >   		return false;
> 
> Should move it here instead of removal?
> 
> /* don't cache block age info for cold file */

Not worth to comment this, as the code is exactly saying that.

> 
> >   	if (file_is_cold(inode))