[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZELu017UCTZWrCjv@casper.infradead.org>
Date: Fri, 21 Apr 2023 21:15:15 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Luis Chamberlain <mcgrof@...nel.org>
Cc: axboe@...nel.dk, agk@...hat.com, snitzer@...nel.org,
philipp.reisner@...bit.com, lars.ellenberg@...bit.com,
christoph.boehmwalder@...bit.com, hch@...radead.org,
djwong@...nel.org, minchan@...nel.org, senozhatsky@...omium.org,
patches@...ts.linux.dev, linux-block@...r.kernel.org,
linux-mm@...ck.org, linux-xfs@...r.kernel.org,
linux-fsdevel@...r.kernel.org, dm-devel@...hat.com,
drbd-dev@...ts.linbit.com, linux-kernel@...r.kernel.org,
hare@...e.de, p.raghav@...sung.com, da.gomez@...sung.com,
kbusch@...nel.org
Subject: Re: [PATCH 1/5] dm integrity: simplify by using PAGE_SECTORS_SHIFT
On Fri, Apr 21, 2023 at 12:58:03PM -0700, Luis Chamberlain wrote:
> - *pl_index = sector >> (PAGE_SHIFT - SECTOR_SHIFT);
> + *pl_index = sector >> (PAGE_SECTORS_SHIFT);
You could/should remove the () around PAGE_SECTORS_SHIFT
(throughout)
Powered by blists - more mailing lists