[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZEMH9h/cd9Cp1t+X@bombadil.infradead.org>
Date: Fri, 21 Apr 2023 15:02:30 -0700
From: Luis Chamberlain <mcgrof@...nel.org>
To: Matthew Wilcox <willy@...radead.org>
Cc: axboe@...nel.dk, agk@...hat.com, snitzer@...nel.org,
philipp.reisner@...bit.com, lars.ellenberg@...bit.com,
christoph.boehmwalder@...bit.com, hch@...radead.org,
djwong@...nel.org, minchan@...nel.org, senozhatsky@...omium.org,
patches@...ts.linux.dev, linux-block@...r.kernel.org,
linux-mm@...ck.org, linux-xfs@...r.kernel.org,
linux-fsdevel@...r.kernel.org, dm-devel@...hat.com,
drbd-dev@...ts.linbit.com, linux-kernel@...r.kernel.org,
hare@...e.de, p.raghav@...sung.com, da.gomez@...sung.com,
kbusch@...nel.org
Subject: Re: [PATCH 3/5] iomap: simplify iomap_init() with PAGE_SECTORS
On Fri, Apr 21, 2023 at 09:14:00PM +0100, Matthew Wilcox wrote:
> On Fri, Apr 21, 2023 at 12:58:05PM -0700, Luis Chamberlain wrote:
> > Just use the PAGE_SECTORS generic define. This produces no functional
> > changes. While at it use left shift to simplify this even further.
>
> How is FOO << 2 simpler than FOO * 4?
>
> > - return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE),
> > + return bioset_init(&iomap_ioend_bioset, PAGE_SECTORS << 2,
We could just do:
- return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE),
+ return bioset_init(&iomap_ioend_bioset, 4 * PAGE_SECTORS,
The shift just seemed optimal if we're just going to change it.
Luis
Powered by blists - more mailing lists