linux-kernel - Re: [PATCH v5 6/6] mfd: tps6586x: register restart handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230421072507.GK996918@google.com>
Date:   Fri, 21 Apr 2023 08:25:07 +0100
From:   Lee Jones <lee@...nel.org>
To:     Benjamin Bara <bbara93@...il.com>
Cc:     benjamin.bara@...data.com, dmitry.osipenko@...labora.com,
        jonathanh@...dia.com, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        peterz@...radead.org, rafael.j.wysocki@...el.com,
        richard.leitner@...ux.dev, treding@...dia.com, wsa@...nel.org
Subject: Re: [PATCH v5 6/6] mfd: tps6586x: register restart handler

On Thu, 20 Apr 2023, Benjamin Bara wrote:

> Thanks for the feedback!
> 
> On Thu, 20 Apr 2023 at 16:04, Lee Jones <lee@...nel.org> wrote:
> > Why 20 here and 50 in the other patch?
> 
> The data sheet states:
> The device will enter the SLEEP or HARD REBOOT state 10ms after the
> SLEEP REQUEST or REBOOT REQUEST is initiated.
> 
> Also:
> When the reboot request state is set an internal timer TWAIT (10ms typ)
> is started (...). The reboot request ends when t > TWAIT.
> 
> But in the electrical characteristics, TWAIT is given as min 18, typ 20,
> max 22.
> 
> In my observations, reboot took like typ 15ms and sleep typ 25ms, but
> this might be very board-specific. I can set both to 50ms to be "on the
> safe side" and have a common value?

The confusing part for me, the reader, was that both say "will take at
least 10ms" or words to that effect, but they sleep for a different
amount of time.

-- 
Lee Jones [李琼斯]