linux-kernel - Re: [PATCH v5 6/6] mfd: tps6586x: register restart handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Apr 2023 09:32:50 +0200
From:   Benjamin Bara <bbara93@...il.com>
To:     lee@...nel.org
Cc:     bbara93@...il.com, benjamin.bara@...data.com,
        dmitry.osipenko@...labora.com, jonathanh@...dia.com,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, peterz@...radead.org,
        rafael.j.wysocki@...el.com, richard.leitner@...ux.dev,
        treding@...dia.com, wsa@...nel.org
Subject: Re: [PATCH v5 6/6] mfd: tps6586x: register restart handler

On Fri, 21 Apr 2023 at 09:25, Lee Jones <lee@...nel.org> wrote:
> The confusing part for me, the reader, was that both say "will take at
> least 10ms" or words to that effect, but they sleep for a different
> amount of time.

Yep, got it. For the next version, I will rewrite to:
"Put the PMIC into * state. Data sheet states that this takes at least 20ms.
As this is board-specific, add some buffer to prevent the timeout error."
and change to -ETIMEDOUT instead of -ETIME.

Thanks!