linux-kernel - Re: [PATCH] counter: stm32-timer-cnt: Reset TIM_TISEL and TIM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230421092451.gzhvwrlyu5v6zdzc@pengutronix.de>
Date:   Fri, 21 Apr 2023 11:24:51 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Lee Jones <lee@...nel.org>
Cc:     kernel@...gutronix.de, Maxime Coquelin <mcoquelin.stm32@...il.com>,
        linux-iio@...r.kernel.org,
        William Breathitt Gray <william.gray@...aro.org>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        linux-kernel@...r.kernel.org,
        Fabrice Gasnier <fabrice.gasnier@...s.st.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Olivier Moysan <olivier.moysan@...s.st.com>,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] counter: stm32-timer-cnt: Reset TIM_TISEL and TIM_SMCR
 to their default value

Hello Lee,

On Thu, Apr 20, 2023 at 12:01:11PM +0100, Lee Jones wrote:
> On Wed, 12 Apr 2023, Uwe Kleine-König wrote:
> 
> > The driver assumes that the input selection register (TIM_TISEL) is at
> > its reset default value. Usually this is the case, but the bootloader
> > might have modified it. Also reset the SMCR register while at it.
> > 
> > This bases on the effectively same patch submitted by Olivier Moysan for
> > pwm-stm32.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > ---
> > Hello,
> > 
> > note that the patch by Olivier Moysan[1] for pwm-stm32 is expected to
> > appear in Thierry's tree soon. It added the definition of TIM_TISEL in
> > the same way, so the two patches should merge just fine. Alternatively
> > you can commit it to a tree that already has the pwm change (and then
> > drop the change to include/linux/mfd/stm32-timers.h from this one).
> > 
> > Best regards
> > Uwe
> > 
> > [1] https://lore.kernel.org/linux-pwm/20221213102707.1096345-1-olivier.moysan@foss.st.com
> > 
> >  drivers/counter/stm32-timer-cnt.c | 4 ++++
> 
> >  include/linux/mfd/stm32-timers.h  | 1 +
> 
> Acked-by: Lee Jones <lee@...nel.org>

Note there is a v2 at
https://lore.kernel.org/r/20230413212339.3611722-1-u.kleine-koenig@pengutronix.de,
William wrote that he already applied it, so replying with tag in that
thread might be already to late, too.

(nevertheless) Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)