linux-kernel - RE: [PATCH v3 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,global-regs-starting-offset' quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6273cc836dee42809f6ac5c5cdbcec04@realtek.com>
Date:   Fri, 21 Apr 2023 16:12:33 +0000
From:   Stanley Chang[昌育德] 
        <stanley_chang@...ltek.com>
To:     Rob Herring <robh+dt@...nel.org>
CC:     Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Felipe Balbi <balbi@...nel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,global-regs-starting-offset' quirk

Hi Rob,

> Again, we're not going to keep adding properties for every DWC3 variation. If
> it is board specific, then yes a property is appropriate. If it is SoC specific, then
> imply it from the compatible.
> Or in this case, you could possibly add another reg entry.
> 
> Rob
> 
Let me try to understand your concerns.

The device-tree property should work for all dwc3 IPs and can be specified by different boards.
For a SoC specific, it should use a compatible or registry entry to change it.
So you think we can't use a property to specify this offset.

Is my understanding correct?

If it is right, using property to solve this problem was my mistake.
I will think a new method to resolve it.