linux-kernel - Re: [PATCH v12 2/3] cachestat: implement cachestat syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202304221702.Ye705xoC-lkp@intel.com>
Date:   Sat, 22 Apr 2023 17:56:49 +0800
From:   kernel test robot <lkp@...el.com>
To:     Nhat Pham <nphamcs@...il.com>, akpm@...ux-foundation.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        hannes@...xchg.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, bfoster@...hat.com,
        willy@...radead.org, linux-api@...r.kernel.org,
        kernel-team@...a.com
Subject: Re: [PATCH v12 2/3] cachestat: implement cachestat syscall

Hi Nhat,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]
[cannot apply to shuah-kselftest/next shuah-kselftest/fixes linus/master tip/x86/asm v6.3-rc7 next-20230421]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nhat-Pham/workingset-refactor-LRU-refault-to-expose-refault-recency-check/20230422-071625
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20230421231421.2401346-3-nphamcs%40gmail.com
patch subject: [PATCH v12 2/3] cachestat: implement cachestat syscall
config: x86_64-randconfig-a016 (https://download.01.org/0day-ci/archive/20230422/202304221702.Ye705xoC-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/9691e4430fbb59890619289b45ee0ce9ec3e97ee
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Nhat-Pham/workingset-refactor-LRU-refault-to-expose-refault-recency-check/20230422-071625
        git checkout 9691e4430fbb59890619289b45ee0ce9ec3e97ee
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304221702.Ye705xoC-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> mm/filemap.c:4293:35: error: expected identifier
   COMPAT_SYSCALL_DEFINE6(cachestat, unsigned int, fd, size_t, len,
                                     ^
>> mm/filemap.c:4293:1: error: type specifier missing, defaults to 'int' [-Werror,-Wimplicit-int]
   COMPAT_SYSCALL_DEFINE6(cachestat, unsigned int, fd, size_t, len,
   ^
>> mm/filemap.c:4297:33: error: implicit declaration of function 'compat_arg_u64_glue' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           return ksys_cachestat(fd, len, compat_arg_u64_glue(off), cstat, flags);
                                          ^
>> mm/filemap.c:4297:24: error: use of undeclared identifier 'fd'
           return ksys_cachestat(fd, len, compat_arg_u64_glue(off), cstat, flags);
                                 ^
>> mm/filemap.c:4297:28: error: use of undeclared identifier 'len'
           return ksys_cachestat(fd, len, compat_arg_u64_glue(off), cstat, flags);
                                     ^
>> mm/filemap.c:4297:53: error: use of undeclared identifier 'off'
           return ksys_cachestat(fd, len, compat_arg_u64_glue(off), cstat, flags);
                                                              ^
>> mm/filemap.c:4297:59: error: use of undeclared identifier 'cstat'
           return ksys_cachestat(fd, len, compat_arg_u64_glue(off), cstat, flags);
                                                                    ^
>> mm/filemap.c:4297:66: error: use of undeclared identifier 'flags'
           return ksys_cachestat(fd, len, compat_arg_u64_glue(off), cstat, flags);
                                                                           ^
>> mm/filemap.c:4293:1: warning: no previous prototype for function 'COMPAT_SYSCALL_DEFINE6' [-Wmissing-prototypes]
   COMPAT_SYSCALL_DEFINE6(cachestat, unsigned int, fd, size_t, len,
   ^
   mm/filemap.c:4293:23: note: declare 'static' if the function is not intended to be used outside of this translation unit
   COMPAT_SYSCALL_DEFINE6(cachestat, unsigned int, fd, size_t, len,
                         ^
                         static 
>> mm/filemap.c:4293:23: error: this old-style function definition is not preceded by a prototype [-Werror,-Wstrict-prototypes]
   COMPAT_SYSCALL_DEFINE6(cachestat, unsigned int, fd, size_t, len,
                         ^
   1 warning and 9 errors generated.


vim +4293 mm/filemap.c

  4291	
  4292	#ifdef CONFIG_COMPAT
> 4293	COMPAT_SYSCALL_DEFINE6(cachestat, unsigned int, fd, size_t, len,
  4294			compat_arg_u64_dual(off), struct cachestat __user *, cstat,
  4295			unsigned int, flags)
  4296	{
> 4297		return ksys_cachestat(fd, len, compat_arg_u64_glue(off), cstat, flags);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests