[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230422182833.7fbf6aae@jic23-huawei>
Date: Sat, 22 Apr 2023 18:28:33 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Mehdi Djait <mehdi.djait.k@...il.com>
Cc: mazziesaccount@...il.com, krzysztof.kozlowski+dt@...aro.org,
andriy.shevchenko@...ux.intel.com, linux-iio@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/5] iio: accel: kionix-kx022a: Warn on failed
matches and assume compatibility
On Thu, 20 Apr 2023 22:22:02 +0200
Mehdi Djait <mehdi.djait.k@...il.com> wrote:
> Avoid error returns on a failure to match and instead just warn with
> assumption that we have a correct dt-binding telling us that
> some new device with a different ID is backwards compatible.
>
> Signed-off-by: Mehdi Djait <mehdi.djait.k@...il.com>
> ---
> v2:
> - no changes, this patch is introduced in the v2
>
> drivers/iio/accel/kionix-kx022a.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/accel/kionix-kx022a.c b/drivers/iio/accel/kionix-kx022a.c
> index f98393d74666..70530005cad3 100644
> --- a/drivers/iio/accel/kionix-kx022a.c
> +++ b/drivers/iio/accel/kionix-kx022a.c
> @@ -1038,9 +1038,7 @@ int kx022a_probe_internal(struct device *dev)
> return dev_err_probe(dev, ret, "Failed to access sensor\n");
>
> if (chip_id != KX022A_ID) {
> - dev_err(dev, "unsupported device 0x%x\n", chip_id);
> - return -EINVAL;
> - }
> + dev_warn(dev, "unsupported device 0x%x\n", chip_id);
Try building this ;) You have remove the closing bracket but kept the opening
one.
Jonathan
>
> irq = fwnode_irq_get_byname(fwnode, "INT1");
> if (irq > 0) {
Powered by blists - more mailing lists