linux-kernel - Re: [PATCH v2 3/5] iio: accel: kionix-kx022a: Refactor driver and add chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230422183246.3b18be8f@jic23-huawei>
Date:   Sat, 22 Apr 2023 18:32:46 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Matti Vaittinen <mazziesaccount@...il.com>
Cc:     Mehdi Djait <mehdi.djait.k@...il.com>,
        krzysztof.kozlowski+dt@...aro.org,
        andriy.shevchenko@...ux.intel.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 3/5] iio: accel: kionix-kx022a: Refactor driver and
 add chip_info structure

On Fri, 21 Apr 2023 09:19:32 +0300
Matti Vaittinen <mazziesaccount@...il.com> wrote:

> Hi Mehdi,
> 
> Thanks for working on this driver :) Much appreciated!
> 
> On 4/20/23 23:22, Mehdi Djait wrote:
> > Refactor the kx022a driver implementation to make it more generic and
> > extensible.
> > Introduce an i2c_device_id table.
> > Add the chip_info structure to the driver's private data to hold all
> > the device specific infos.
> > 
> > Signed-off-by: Mehdi Djait <mehdi.djait.k@...il.com>
> > ---
> > v2:
> > - mentioned the introduction of the i2c_device_id table in the commit  
> 
> Maybe adding the i2c_device_id table could be done in a separate patch 
> with a Fixes tag? That would help backporting (and I think changes like 
> this are worth it).

Is it technically a fix?  I thought it was but turned out my reasoning only
applied to spi.   Agreed it would be nice as a separate patch though.
It's not directly related to the rest of what is happening here.