linux-kernel - Re: [PATCH] drivers: regulator: core: remove return value check of `regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <888091b8-b83e-4999-b5a4-04e6d6d36bc2@sirena.org.uk>
Date:   Mon, 24 Apr 2023 12:55:50 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Yuchen Yang <u202114568@...t.edu.cn>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        hust-os-kernel-patches@...glegroups.com,
        Dongliang Mu <dzm91@...t.edu.cn>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: regulator: core: remove return value check of
 `regulator_init`

On Sun, Apr 23, 2023 at 08:27:31PM +0800, Yuchen Yang wrote:
> Smatch complains that:
> regulator_init() warn: 'debugfs_root' is an error pointer or valid
> 
> According to the documentation of the debugfs_create_dir() function,
> there is no need to check the return value of this function.
> Just delete the dead code.

This is very much a taste and use case question, you can't just delete
error checks without thought.

> Fixes: 247514344492 ("regulator: Remove ifdefs for debugfs code")

Don't just throw random Fixes tags on things :(

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)