linux-kernel - Re: [PATCH] spi: remove return value check of debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb3c6aa6-6820-4e94-8eb0-5abd3b627fcc@sirena.org.uk>
Date:   Mon, 24 Apr 2023 12:54:48 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Yingsha Xu <ysxu@...t.edu.cn>
Cc:     Serge Semin <fancer.lancer@...il.com>,
        hust-os-kernel-patches@...glegroups.com, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: remove return value check of debugfs_create_dir()

On Sun, Apr 23, 2023 at 02:11:54PM +0800, Yingsha Xu wrote:
> Smatch complains that:
> dw_spi_debugfs_init() warn: 'dws->debugfs' is an error pointer
>  or valid
> 
> Debugfs checks are generally not supposed to be checked for errors
> and it is not necessary here.
> 
> Just delete the dead code.

This is very much a question of taste with a range of use cases
available.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)