linux-kernel - Re: [PATCH] spi: remove return value check of debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <368e31ae-31b5-839f-72e3-20a27239cb0b@sony.com>
Date:   Mon, 24 Apr 2023 14:20:45 +0200
From:   Peter Enderborg <peter.enderborg@...y.com>
To:     Mark Brown <broonie@...nel.org>, Yingsha Xu <ysxu@...t.edu.cn>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Serge Semin <fancer.lancer@...il.com>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: remove return value check of debugfs_create_dir()

On 4/24/23 13:54, Mark Brown wrote:
> On Sun, Apr 23, 2023 at 02:11:54PM +0800, Yingsha Xu wrote:
>> Smatch complains that:
>> dw_spi_debugfs_init() warn: 'dws->debugfs' is an error pointer
>>  or valid
>>
>> Debugfs checks are generally not supposed to be checked for errors
>> and it is not necessary here.
>>
>> Just delete the dead code.
> 
> This is very much a question of taste with a range of use cases
> available.

No. 
https://lkml.iu.edu/hypermail/linux/kernel/1901.2/05993.html
We can do things with the debug information without filesystem enabled.