linux-kernel - Re: [PATCH v2] net: phy: add driver for MediaTek SoC built-in GE PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZEePDK2oW5xkiEIv@makrotopia.org>
Date:   Tue, 25 Apr 2023 09:27:56 +0100
From:   Daniel Golle <daniel@...rotopia.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org,
        linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Qingfang Deng <dqfext@...il.com>,
        SkyLake Huang <SkyLake.Huang@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v2] net: phy: add driver for MediaTek SoC built-in GE PHYs

On Mon, Apr 24, 2023 at 06:37:55PM -0700, Jakub Kicinski wrote:
> On Sat, 22 Apr 2023 13:36:58 +0100 Daniel Golle wrote:
> > Some of MediaTek's Filogic SoCs come with built-in gigabit Ethernet
> > PHYs which require calibration data from the SoC's efuse.
> > Despite the similar design the driver doesn't share any code with the
> > existing mediatek-ge.c, so add support for these PHYs by introducing a
> > new driver for only MediaTek's ARM64 SoCs.
> 
> Andrew, Heiner, how do you feel about this driver?
> 
> Daniel, is it high prio for you to get it into 6.4 or 6.5 is okay?

No rush, as this is mostly relevant for OpenWrt the thing which matters
most to me is having it in the next LTS kernel, so 6.5 should still be
fine I suppose.

> 
> I'm trying to get a read on whether we should merge it because it's 
> kind of on the goal line for this merge window. 
> 
> If nobody feels strongly we can do this the traditional way - I'll 
> just complain about RCT, hence kicking it back out into the field :)

I understand Andrew's concerns and will resubmit for the next merge
window in 2 weeks, and without the LED part for now until PHY LED
infrastructure is more ready (ie. able to offload 'netdev' trigger
to hardware)