linux-kernel - Re: [PATCH RESEND] usb: dwc3: remove dead code in dwc3_otg_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <887b6226-ea4f-e75c-bfde-0785ccf30c77@omp.ru>
Date:   Tue, 25 Apr 2023 11:57:18 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     lihuya <lihuya@...t.edu.cn>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     <hust-os-kernel-patches@...glegroups.com>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] usb: dwc3: remove dead code in dwc3_otg_get_irq

Hello!

On 4/24/23 1:59 PM, lihuya wrote:

> platform_get_irq() only return non-zero irq number on success, or
> negative error number on failure.
> 
> There is no need to check the return value of platform_get_irq()
> to determine the return value of dwc3_otg_get_irq(), removing
> them to solve this problem.

   I was going to submit such patch myself at some point... which
has never happened. :-/

> Signed-off-by: lihuya <lihuya@...t.edu.cn>

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]

MBR, Sergey