linux-kernel - Re: [PATCH RESEND] usb: dwc3: remove dead code in dwc3_otg_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <559cf3a3-f740-89d3-9e63-d0016d767a8a@hust.edu.cn>
Date:   Tue, 25 Apr 2023 17:10:14 +0800
From:   Dongliang Mu <dzm91@...t.edu.cn>
To:     Sergey Shtylyov <s.shtylyov@....ru>, lihuya <lihuya@...t.edu.cn>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     hust-os-kernel-patches@...glegroups.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] usb: dwc3: remove dead code in dwc3_otg_get_irq


On 2023/4/25 16:57, Sergey Shtylyov wrote:
> Hello!
>
> On 4/24/23 1:59 PM, lihuya wrote:
>
>> platform_get_irq() only return non-zero irq number on success, or
>> negative error number on failure.
>>
>> There is no need to check the return value of platform_get_irq()
>> to determine the return value of dwc3_otg_get_irq(), removing
>> them to solve this problem.
>     I was going to submit such patch myself at some point... which
> has never happened. :-/
>
>> Signed-off-by: lihuya <lihuya@...t.edu.cn>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

Hi Sergey,

Please take a look at the following thread [1]. Yuhang sent a v2 patch 
since he did not use his real name in the Signed-off-by.

Greg already had some comments on this patch.

[1] https://lore.kernel.org/lkml/20230425015532.13622-1-lihuya@hust.edu.cn/

>
> [...]
>
> MBR, Sergey
>