linux-kernel - Re: [PATCH 2/4] ARM: dts: aspeed: mtmitchell: Add I2C Fan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ee3eec8-b5b4-2591-adcd-1831bf7de02b@linaro.org>
Date:   Tue, 25 Apr 2023 15:15:08 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Chanh Nguyen <chanh@...amperecomputing.com>,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] ARM: dts: aspeed: mtmitchell: Add I2C Fan

On 25/04/2023 08:57, Chanh Nguyen wrote:
> Add the MAX31790 node as a Fan I2C controller. It controls the
> TACH and PWM for Fan Mt.Mitchell system.
> 
> Signed-off-by: Chanh Nguyen <chanh@...amperecomputing.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
> index e79f56208b89..6455cf80da0e 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
> @@ -477,6 +477,18 @@
>  			line-name = "bmc-ocp0-en-n";
>  		};
>  	};
> +
> +	max31790@20 {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> +		compatible = "maxim,max31790";

Unfortunately the compatible is undocumented.

Please run scripts/checkpatch.pl and fix reported warnings.

Best regards,
Krzysztof