linux-kernel - Re: [PATCH v2] clk: qcom: gcc-ipq6018: Use floor ops for sdcc clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <094e0cec-5a9b-abfc-74b0-9d3af10f9275@linaro.org>
Date:   Tue, 25 Apr 2023 14:44:10 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Mantas Pucka <mantas@...vices.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] clk: qcom: gcc-ipq6018: Use floor ops for sdcc clocks


On 4/25/23 10:11, Mantas Pucka wrote:
> SDCC clocks must be rounded down to avoid overclocking the controller.
>
> Fixes: d9db07f088af ("clk: qcom: Add ipq6018 Global Clock Controller support")
> Signed-off-by: Mantas Pucka <mantas@...vices.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>


Konrad

> v2: remove unnecessary newline in commit message
>
>   drivers/clk/qcom/gcc-ipq6018.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq6018.c b/drivers/clk/qcom/gcc-ipq6018.c
> index 3f9c2f61a5d9..5c5d1b04ea7a 100644
> --- a/drivers/clk/qcom/gcc-ipq6018.c
> +++ b/drivers/clk/qcom/gcc-ipq6018.c
> @@ -1654,7 +1654,7 @@ static struct clk_rcg2 sdcc1_apps_clk_src = {
>   		.name = "sdcc1_apps_clk_src",
>   		.parent_data = gcc_xo_gpll0_gpll2_gpll0_out_main_div2,
>   		.num_parents = 4,
> -		.ops = &clk_rcg2_ops,
> +		.ops = &clk_rcg2_floor_ops,
>   	},
>   };
>