linux-kernel - Re: [PATCH v2 4/5] iio: light: ROHM BU27008 color sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Apr 2023 16:45:18 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Matti Vaittinen <mazziesaccount@...il.com>
Cc:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Zhigang Shi <Zhigang.Shi@...eon.com>,
        Shreeya Patel <shreeya.patel@...labora.com>,
        Paul Gazzillo <paul@...zz.com>,
        Dmitry Osipenko <dmitry.osipenko@...labora.com>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/5] iio: light: ROHM BU27008 color sensor

On Tue, Apr 25, 2023 at 08:24:01AM +0300, Matti Vaittinen wrote:
> On 4/24/23 18:22, Andy Shevchenko wrote:
> > On Mon, Apr 24, 2023 at 04:10:09PM +0300, Matti Vaittinen wrote:

...

> > This...
> > 
> > > +#include <linux/bits.h>
> > 
> > ...is guaranteed to be included by this.
> > 
> > > +#include <linux/bitops.h>
> 
> Out of the curiosity - do we have a rule and rationale for explicitly
> including headers with 'stuff' we use Vs. trusting some header being
> included by another one? I've not thought much of this so I don't know if
> there are any pros/cons?

That's what we are starving for actually. Currently this is a tribe knowledge
which one gets while being involved into Linux kernel development for a long
time and being capable of keeping an eye on tree wide, library or similar
changes.

I would love to see some (preferably generated) list of the header
dependencies. Yet, the header dependency hell should be solved meanwhile
(see Ingo's 2k+ patch series).

-- 
With Best Regards,
Andy Shevchenko