linux-kernel - Re: [PATCH 02/34] maple_tree: Clean up mas_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230425161356.yfjhn2uoq32pbp6r@master>
Date:   Tue, 25 Apr 2023 16:13:56 +0000
From:   Wei Yang <richard.weiyang@...il.com>
To:     "Liam R. Howlett" <Liam.Howlett@...cle.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        maple-tree@...ts.infradead.org,
        Wei Yang <richard.weiyang@...il.com>
Subject: Re: [PATCH 02/34] maple_tree: Clean up mas_parent_enum()

On Tue, Apr 25, 2023 at 10:09:23AM -0400, Liam R. Howlett wrote:
>From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
>
>mas_parent_enum() is a simple wrapper for mte_parent_enum() which is
>only called from that wrapper.  Remove the wrapper and inline
>mte_parent_enum() into mas_parent_enum().
>
>At the same time, clean up the bit masking of the root pointer since it
>cannot be set by the time the bit masking occurs.  Change the check on
>the root bit to a WARN_ON(), and fix the verification code to not
>trigger the WARN_ON() before checking if the node is root.
>
>Reported-by: Wei Yang <richard.weiyang@...il.com>
>Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>

Reviewed-by: Wei Yang <richard.weiyang@...il.com>

-- 
Wei Yang
Help you, Help me