linux-kernel - Re: [PATCH v2] mei: deduplicate X86 && PCI dependencies, make them apply to all subentries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023042519-spookily-vocalist-51d2@gregkh>
Date:   Tue, 25 Apr 2023 18:16:36 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     kilobyte@...band.pl
Cc:     "Winkler, Tomas" <tomas.winkler@...el.com>,
        Arnd Bergmann <arnd@...db.de>,
        "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mei: deduplicate X86 && PCI dependencies, make them
 apply to all subentries

On Tue, Apr 25, 2023 at 05:43:14PM +0200, kilobyte@...band.pl wrote:
> From: Adam Borowski <kilobyte@...band.pl>
> 
> The Kconfig "depends on X86 && PCI" line was repeated for 4 out of 6 config
> symbols here -- which was both unnecessarily repetitive, and caused a
> dormant problem for the two remaining symbols lacking the dependency.
> 
> Signed-off-by: Adam Borowski <kilobyte@...band.pl>
> ---
>  v2: instead of adding new depends, wrap all of mei in "if..endif"
> 
>  drivers/misc/mei/Kconfig | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig
> index d21486d69df2..f2ab2696fa78 100644
> --- a/drivers/misc/mei/Kconfig
> +++ b/drivers/misc/mei/Kconfig
> @@ -1,8 +1,8 @@
>  # SPDX-License-Identifier: GPL-2.0
>  # Copyright (c) 2003-2019, Intel Corporation. All rights reserved.
> +if X86 && PCI

Please no, that's not a normal Kconfig thing to do at all, sorry.

greg k-h