[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230426063541.15378-3-samin.guo@starfivetech.com>
Date: Wed, 26 Apr 2023 14:35:41 +0800
From: Samin Guo <samin.guo@...rfivetech.com>
To: <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
<netdev@...r.kernel.org>, Peter Geis <pgwipeout@...il.com>,
Frank <Frank.Sae@...or-comm.com>
CC: "David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Andrew Lunn <andrew@...n.ch>,
"Heiner Kallweit" <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"Samin Guo" <samin.guo@...rfivetech.com>,
Yanhong Wang <yanhong.wang@...rfivetech.com>
Subject: [PATCH v1 2/2] net: phy: motorcomm: Add pad drive strength cfg support
The motorcomm phy (YT8531) supports the ability to adjust the drive
strength of the rx_clk/rx_data, and the default strength may not be
suitable for all boards. So add configurable options to better match
the boards.(e.g. StarFive VisionFive 2)
Signed-off-by: Samin Guo <samin.guo@...rfivetech.com>
---
drivers/net/phy/motorcomm.c | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
index 2fa5a90e073b..08f28ed83e60 100644
--- a/drivers/net/phy/motorcomm.c
+++ b/drivers/net/phy/motorcomm.c
@@ -236,6 +236,11 @@
*/
#define YTPHY_WCR_TYPE_PULSE BIT(0)
+#define YTPHY_PAD_DRIVE_STRENGTH_REG 0xA010
+#define YTPHY_RGMII_RXC_DS GENMASK(15, 13)
+#define YTPHY_RGMII_RXD_DS GENMASK(5, 4) /* Bit 1 and 0 of rgmii_rxd_ds */
+#define YTPHY_RGMII_RXD_DS2 BIT(12) /* Bit 2 of rgmii_rxd_ds */
+
#define YTPHY_SYNCE_CFG_REG 0xA012
#define YT8521_SCR_SYNCE_ENABLE BIT(5)
/* 1b0 output 25m clock
@@ -1495,6 +1500,7 @@ static int yt8531_config_init(struct phy_device *phydev)
{
struct device_node *node = phydev->mdio.dev.of_node;
int ret;
+ u32 val;
ret = ytphy_rgmii_clk_delay_config_with_lock(phydev);
if (ret < 0)
@@ -1518,6 +1524,32 @@ static int yt8531_config_init(struct phy_device *phydev)
return ret;
}
+ if (!of_property_read_u32(node, "rx-clk-driver-strength", &val)) {
+ ret = ytphy_modify_ext_with_lock(phydev,
+ YTPHY_PAD_DRIVE_STRENGTH_REG,
+ YTPHY_RGMII_RXC_DS,
+ FIELD_PREP(YTPHY_RGMII_RXC_DS, val));
+ if (ret < 0)
+ return ret;
+ }
+
+ if (!of_property_read_u32(node, "rx-data-driver-strength", &val)) {
+ if (val > FIELD_MAX(YTPHY_RGMII_RXD_DS)) {
+ val &= FIELD_MAX(YTPHY_RGMII_RXD_DS);
+ val = FIELD_PREP(YTPHY_RGMII_RXD_DS, val);
+ val |= YTPHY_RGMII_RXD_DS2;
+ } else {
+ val = FIELD_PREP(YTPHY_RGMII_RXD_DS, val);
+ }
+
+ ret = ytphy_modify_ext_with_lock(phydev,
+ YTPHY_PAD_DRIVE_STRENGTH_REG,
+ YTPHY_RGMII_RXD_DS | YTPHY_RGMII_RXD_DS2,
+ val);
+ if (ret < 0)
+ return ret;
+ }
+
return 0;
}
--
2.17.1
Powered by blists - more mailing lists