[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230426074453.GD4724@pengutronix.de>
Date: Wed, 26 Apr 2023 09:44:53 +0200
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Daniel Golle <daniel@...rotopia.org>
Cc: netdev@...r.kernel.org, linux-mediatek@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Andrew Lunn <andrew@...n.ch>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Sean Wang <sean.wang@...iatek.com>,
Landen Chao <Landen.Chao@...iatek.com>,
DENG Qingfang <dqfext@...il.com>,
Russell King <linux@...linux.org.uk>,
Arınç Ünal <arinc.unal@...nc9.com>,
Sam Shih <Sam.Shih@...iatek.com>,
Lorenzo Bianconi <lorenzo@...nel.org>,
John Crispin <john@...ozen.org>, Felix Fietkau <nbd@....name>
Subject: Re: [PATCH net-next v2 13/14] net: dsa: mt7530: introduce driver for
MT7988 built-in switch
Hi Daniel,
On Tue, Apr 25, 2023 at 05:11:36PM +0100, Daniel Golle wrote:
> On Tue, Apr 25, 2023 at 05:51:37PM +0200, Philipp Zabel wrote:
[...]
> > Please use devm_reset_control_get_exclusive() directly.
> >
> > > + if (IS_ERR(priv->rstc)) {
> > > + dev_err(&pdev->dev, "Couldn't get our reset line\n");
> > > + return PTR_ERR(priv->rstc);
> >
> > Not sure if this can actually happen, but there is no need to warn on
> > -EPROBE_DEFER. You could use return dev_err_probe(...) here.
>
> Thank you for your comments. The series has already been picked to
> net-next. Unless you want to send the suggested changes yourself, I will
> prepare another series with your suggestions, and also apply them to
> mt7530-mdio.c.
That would be great, thank you.
regards
Philipp
Powered by blists - more mailing lists