linux-kernel - Re: [PATCH 1/2] thermal/governors/step

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0ha1TDPV7auMt-xNiM03ShLdA-SgWTrffx=CLxnvZijxQ@mail.gmail.com>
Date:   Thu, 27 Apr 2023 19:07:46 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Zhang Rui <rui.zhang@...el.com>
Cc:     linux-pm@...r.kernel.org, rafael.j.wysocki@...el.com,
        daniel.lezcano@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] thermal/governors/step_wise: delete obsolete comment

On Tue, Mar 21, 2023 at 6:47 AM Zhang Rui <rui.zhang@...el.com> wrote:
>
> Commit 4102c4042a33 ("thermal/core: Remove DROP_FULL and RAISE_FULL")
> removes support for THERMAL_TREND_RAISE_FULL/DROP_FULL but leaves the
> comment unchanged.
>
> Delete the obsolte comment about THERMAL_TREND_RAISE_FULL/DROP_FULL.
>
> Fixes: 4102c4042a33 ("thermal/core: Remove DROP_FULL and RAISE_FULL")
> Signed-off-by: Zhang Rui <rui.zhang@...el.com>
> ---
>  drivers/thermal/gov_step_wise.c | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/drivers/thermal/gov_step_wise.c b/drivers/thermal/gov_step_wise.c
> index 31235e169c5a..7a760b6a4279 100644
> --- a/drivers/thermal/gov_step_wise.c
> +++ b/drivers/thermal/gov_step_wise.c
> @@ -21,19 +21,11 @@
>   *    a. if the trend is THERMAL_TREND_RAISING, use higher cooling
>   *       state for this trip point
>   *    b. if the trend is THERMAL_TREND_DROPPING, do nothing
> - *    c. if the trend is THERMAL_TREND_RAISE_FULL, use upper limit
> - *       for this trip point
> - *    d. if the trend is THERMAL_TREND_DROP_FULL, use lower limit
> - *       for this trip point
>   * If the temperature is lower than a trip point,
>   *    a. if the trend is THERMAL_TREND_RAISING, do nothing
>   *    b. if the trend is THERMAL_TREND_DROPPING, use lower cooling
>   *       state for this trip point, if the cooling state already
>   *       equals lower limit, deactivate the thermal instance
> - *    c. if the trend is THERMAL_TREND_RAISE_FULL, do nothing
> - *    d. if the trend is THERMAL_TREND_DROP_FULL, use lower limit,
> - *       if the cooling state already equals lower limit,
> - *       deactivate the thermal instance
>   */
>  static unsigned long get_target_state(struct thermal_instance *instance,
>                                 enum thermal_trend trend, bool throttle)
> --

Applied as 6.4-rc material along with the [2/2], thanks!