linux-kernel - Re: [Intel-gfx] [PATCH v8 2/2] drm/i915: Use correct huge page manager for MTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZEuM33M1J2SlDuTp@ashyti-mobl2.lan>
Date:   Fri, 28 Apr 2023 11:07:43 +0200
From:   Andi Shyti <andi.shyti@...el.com>
To:     Andrzej Hajda <andrzej.hajda@...el.com>
Cc:     intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Jonathan Cavitt <jonathan.cavitt@...el.com>,
        Matthew Auld <matthew.auld@...el.com>
Subject: Re: [Intel-gfx] [PATCH v8 2/2] drm/i915: Use correct huge page
 manager for MTL

Hi Andrzej,

> MTL currently uses gen8_ppgtt_insert_huge when managing huge pages.
> This is because MTL reports as not supporting 64K pages, or more
> accurately, the system that reports whether a platform has 64K pages
> reports false for MTL.  This is only half correct, as the 64K page support
> reporting system only cares about 64K page support for LMEM, which MTL
> doesn't have.
> 
> MTL should be using xehpsdv_ppgtt_insert_huge.  However, simply changing
> over to using that manager doesn't resolve the issue because MTL is
> expecting the virtual address space for the page table to be flushed after
> initialization, so we must also add a flush statement there.
> 
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@...el.com>
> Reviewed-by: Matthew Auld <matthew.auld@...el.com>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@...el.com>

Reviewed-by: Andi Shyti <andi.shyti@...ux.intel.com> 

Andi