linux-kernel - Re: [PATCH -next] soc: ti: smartreflex: Use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <951f0163-4b84-d12c-9c9a-8102abb51cfd@ti.com>
Date:   Fri, 28 Apr 2023 15:32:19 +0530
From:   Dhruva Gole <d-gole@...com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, <nm@...com>
CC:     <ssantosh@...nel.org>, <linux-pm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH -next] soc: ti: smartreflex: Use
 devm_platform_ioremap_resource()

Hi,

On 28/04/23 11:58, Yang Li wrote:
> Convert platform_get_resource(),devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource(), as this is exactly what this
> function does.
> 
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>   drivers/soc/ti/smartreflex.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c
> index da7898239a46..62b2f1464e46 100644
> --- a/drivers/soc/ti/smartreflex.c
> +++ b/drivers/soc/ti/smartreflex.c
> @@ -815,7 +815,6 @@ static int omap_sr_probe(struct platform_device *pdev)
>   {
>   	struct omap_sr *sr_info;
>   	struct omap_sr_data *pdata = pdev->dev.platform_data;
> -	struct resource *mem;
>   	struct dentry *nvalue_dir;
>   	int i, ret = 0;
>   
> @@ -835,8 +834,7 @@ static int omap_sr_probe(struct platform_device *pdev)
>   		return -EINVAL;
>   	}
>   
> -	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	sr_info->base = devm_ioremap_resource(&pdev->dev, mem);
> +	sr_info->base = devm_platform_ioremap_resource(pdev, 0);


Reviewed-by: Dhruva Gole <d-gole@...com>

>   	if (IS_ERR(sr_info->base))
>   		return PTR_ERR(sr_info->base);
>   

-- 
Thanks and Regards,
Dhruva Gole