linux-kernel - Re: [PATCH] crypto: sun8i-ss - Fix a test in sun8i_ss_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZEuaXi5LCCSYa/ll@gondor.apana.org.au>
Date:   Fri, 28 Apr 2023 18:05:18 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Corentin Labbe <clabbe.montjoie@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Corentin Labbe <clabbe@...libre.com>,
        linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH] crypto: sun8i-ss - Fix a test in sun8i_ss_setup_ivs()

On Mon, Apr 17, 2023 at 10:25:09PM +0200, Christophe JAILLET wrote:
> SS_ENCRYPTION is (0 << 7 = 0), so the test can never be true.
> Use a direct comparison to SS_ENCRYPTION instead.
> 
> The same king of test is already done the same way in sun8i_ss_run_task().
> 
> Fixes: 359e893e8af4 ("crypto: sun8i-ss - rework handling of IV")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Untested
> ---
>  drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt