[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230428012235.119333-2-raghuhack78@gmail.com>
Date: Fri, 28 Apr 2023 01:22:34 +0000
From: Raghu H <raghuhack78@...il.com>
To: linux-cxl@...r.kernel.org,
Alison Schofield <alison.schofield@...el.com>,
raghuhack78@...il.com, ira.weiny@...el.com, bwidawsk@...nel.org,
dan.j.williams@...el.com, vishal.l.verma@...el.com
Cc: linux-kernel@...r.kernel.org
Subject: [PATCH v2 1/2] cxl/mbox: Remove redundant dev_err() after failed mem alloc
Issue found with checkpatch
A return of errno should be good enough if the memory allocation fails,
the error message here is redundatant as per the coding style, removing it.
Signed-off-by: Raghu H <raghuhack78@...il.com>
---
drivers/cxl/core/mbox.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
index f2addb457172..11ea145b4b1f 100644
--- a/drivers/cxl/core/mbox.c
+++ b/drivers/cxl/core/mbox.c
@@ -1112,10 +1112,8 @@ struct cxl_dev_state *cxl_dev_state_create(struct device *dev)
struct cxl_dev_state *cxlds;
cxlds = devm_kzalloc(dev, sizeof(*cxlds), GFP_KERNEL);
- if (!cxlds) {
- dev_err(dev, "No memory available\n");
+ if (!cxlds)
return ERR_PTR(-ENOMEM);
- }
mutex_init(&cxlds->mbox_mutex);
mutex_init(&cxlds->event.log_lock);
--
2.39.2
Powered by blists - more mailing lists