linux-kernel - Re: [PATCH v2 1/2] cxl/mbox: Remove redundant dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d232ddc-446c-bfca-71f4-51182356e974@intel.com>
Date:   Mon, 1 May 2023 07:52:17 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Raghu H <raghuhack78@...il.com>, linux-cxl@...r.kernel.org,
        Alison Schofield <alison.schofield@...el.com>,
        ira.weiny@...el.com, bwidawsk@...nel.org, dan.j.williams@...el.com,
        vishal.l.verma@...el.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] cxl/mbox: Remove redundant dev_err() after failed
 mem alloc



On 4/27/23 6:22 PM, Raghu H wrote:
> Issue found with checkpatch
> 
> A return of errno should be good enough if the memory allocation fails,
> the error message here is redundatant as per the coding style, removing it.
> 
> Signed-off-by: Raghu H <raghuhack78@...il.com>
Reviewed-by: Dave Jiang <dave.jiang@...el.com>

> ---
>   drivers/cxl/core/mbox.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index f2addb457172..11ea145b4b1f 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -1112,10 +1112,8 @@ struct cxl_dev_state *cxl_dev_state_create(struct device *dev)
>   	struct cxl_dev_state *cxlds;
>   
>   	cxlds = devm_kzalloc(dev, sizeof(*cxlds), GFP_KERNEL);
> -	if (!cxlds) {
> -		dev_err(dev, "No memory available\n");
> +	if (!cxlds)
>   		return ERR_PTR(-ENOMEM);
> -	}
>   
>   	mutex_init(&cxlds->mbox_mutex);
>   	mutex_init(&cxlds->event.log_lock);